Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] change default alerts to empty hash #152

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

costela
Copy link

@costela costela commented Jan 31, 2018

This should fix promtool parsing problems for prometheus 2.* and empty alert files. Behaviour for 1.* should remain unchanged.

Fixes #143

This should fix `promtool` parsing problems for prometheus 2.* and empty alert files. Behaviour for 1.* should remain unchanged.

Fixes voxpupuli#143
@costela costela changed the title Change default alerts to empty hash [minor] change default alerts to empty hash Jan 31, 2018
@tuxmea
Copy link
Member

tuxmea commented Jan 31, 2018

I saw the thread on #143 (comment). looks good to me

@juniorsysadmin juniorsysadmin added the bug Something isn't working label Feb 1, 2018
@bastelfreak bastelfreak merged commit bd5682c into voxpupuli:master Feb 2, 2018
@costela costela deleted the patch-1 branch February 2, 2018 10:02
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
[minor] change default alerts to empty hash
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
[minor] change default alerts to empty hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert rule validation error
4 participants