Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to data-in-modules #178

Merged
merged 43 commits into from
Mar 22, 2018
Merged

Convert to data-in-modules #178

merged 43 commits into from
Mar 22, 2018

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak added enhancement New feature or request needs-work not ready to merge just yet labels Mar 18, 2018
@bastelfreak bastelfreak force-pushed the cleanup branch 2 times, most recently from cc7dcee to ecfa60c Compare March 18, 2018 11:56
@bastelfreak bastelfreak force-pushed the cleanup branch 4 times, most recently from 716095f to a326a11 Compare March 18, 2018 13:43
@bastelfreak bastelfreak removed the needs-work not ready to merge just yet label Mar 18, 2018
@bastelfreak
Copy link
Member Author

There are a few things that currently don't get their default value from the params.pp. I didn't move those to hiera. The diff is already pretty big. We can migrate the other params in another PR.

@bastelfreak bastelfreak merged commit 78bbbe6 into master Mar 22, 2018
@bastelfreak bastelfreak deleted the cleanup branch March 22, 2018 11:36
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants