Remove double quotes from source_labels value with gsub #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value in source_labels have to be without quotes, but sometimes you have to use brackets in the value and puppet surrounds it with double quotes. So we need to replace the double quotes with nothing in the template
|
Thanks for the PR @sebastianrakel ! |
sebastianrakel
changed the title
sebastianrakel
changed the title
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Remove double quotes from source_labels value with gsub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The value in source_labels have to be without quotes, but sometimes you
have to use brackets in the value and puppet surrounds it with double
quotes.
So we need to replace the double quotes with nothing in the template