Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move systemd files to /etc #30

Closed
wants to merge 1 commit into from
Closed

Conversation

snubba
Copy link
Contributor

@snubba snubba commented Dec 12, 2016

To be able to install prometheus from package with systemd file, move the systemd file generated with puppet to /etc
So we can install from a package and be able to customize the systemd file via puppet.

see https://www.freedesktop.org/software/systemd/man/systemd.unit.html#Unit%20File%20Load%20Path

@brutus333
Copy link
Collaborator

From some point of view seems the right thing to do especially when not installing from package; however, I do not know if it will not bring some confusion to have two files for same configuration (I should test even the functionality).
Don't you think is better to change the package contained file in place (after installing the package, of course)?

@snubba
Copy link
Contributor Author

snubba commented Dec 12, 2016

The replacement of the file in place needs a puppet run to change it back. If you update the package via a different method, you will run on an default config.
If there is an file in /etc, the file in /lib will be ignored, so you can manage the package separate from puppet.

@ntnn
Copy link

ntnn commented Dec 12, 2016

@brutus333

The service files under /etc/systemd/system are for user-placed files, the files under /lib/systemd/system are for packaged service files. Hence changing the packaged service file goes against what these locations are for. Nevermind that - misunderstood your sentence.

Anyhow - the files under /lib are not meant for the user to change, e.g. to be updated by packages at will. This means that a packaged service file in /lib should also overwrite the changes a user made to the file in /lib.

@brutus333
Copy link
Collaborator

It will be incorporated in #27

@brutus333
Copy link
Collaborator

Changes included in #27

@brutus333 brutus333 closed this Dec 27, 2016
roidelapluie pushed a commit that referenced this pull request Jun 21, 2017
Support alerting configuration for prometheus
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
Support alerting configuration for prometheus
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Support alerting configuration for prometheus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants