Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the aarch64 architecture #300

Merged
merged 1 commit into from
Mar 10, 2019
Merged

Conversation

ralimi
Copy link

@ralimi ralimi commented Mar 2, 2019

Pull Request (PR) description

Add support for the aarch64 architecture

This Pull Request (PR) fixes the following issues

n/a

@ralimi ralimi marked this pull request as ready for review March 2, 2019 07:45
@bastelfreak bastelfreak added the enhancement New feature or request label Mar 2, 2019
@bastelfreak
Copy link
Member

Hi @ralimi, thanks for the PR. Do you have an aarch64 platform by hand and could provide facts to https://github.com/camptocamp/facterdb ? Or as an alternative, could you mock this architecture in our current tests so we can ensure that everything still compiles?

@ralimi
Copy link
Author

ralimi commented Mar 2, 2019

Thanks for the quick feedback!

I looked briefly at contributing to facterdb and, if I understand correctly, the way to get things included as part of the standard release is to have a vagrant box. From https://app.vagrantup.com/boxes/search?utf8=%E2%9C%93&sort=downloads&provider=&q=arm64 (I did an equivalent search for aarch64 too), it doesn't seem like there is an appealing/regularly-maintained option. Let me know if I'm misunderstanding things there.

I'll dig around the unit tests to see where best to mock this. A quick search (e.g., for armv7l) didn't yield examples. Let me know if I'm missing something there.

@bastelfreak
Copy link
Member

you can have a look at https://github.com/camptocamp/facterdb/blob/master/facts/get_facts.sh. It's basically enough to run facter -j and put the output into a file. That's also the way I used to get the archlinux facts that are in facterdb.

@ralimi
Copy link
Author

ralimi commented Mar 5, 2019

Hi @bastelfreak, what are the next steps here?

So far:

  • I've got this running successfully in my local setup.
  • Facts have be added to facterdb.

If I understand correctly, this wouldn't be used in tests until the next facterdb release. If that understanding is correct, what is the best thing to do before then?

@bastelfreak
Copy link
Member

Thanks for the work!

@bastelfreak bastelfreak merged commit 72b3da9 into voxpupuli:master Mar 10, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Aug 28, 2019
Add support for the aarch64 architecture
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
Add support for the aarch64 architecture
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants