Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subbing out @name in stop function with an ambiguous name. #314

Merged
merged 1 commit into from
May 20, 2019
Merged

subbing out @name in stop function with an ambiguous name. #314

merged 1 commit into from
May 20, 2019

Conversation

strings48066
Copy link

Pull Request (PR) description

The template daemon.sysv.erb creates a variable name using @name as its value. When applying the process-exporter this variable is named process-exporter and produces the following:

$ service process-exporter stop
Shutting down prometheus process-exporter: /etc/init.d/process-exporter: line 68: process-exporter_pid=17693: command not found

Modified the variable creation to use a static name that conforms to the naming rules for variables.

This Pull Request (PR) fixes the following issues

Fixes #311

@bastelfreak
Copy link
Member

Hi @strings48066, thanks for the bugfix!

@bastelfreak bastelfreak added the bug Something isn't working label May 20, 2019
@bastelfreak bastelfreak merged commit fb5b799 into voxpupuli:master May 20, 2019
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
subbing out @name in stop function with an ambiguous name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Process-exporter sysv init stop process command not found
2 participants