prohibit empty service_provider fact #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd also remove the if statement on |
This module depends on the variable `prometheus::init_style` being set to a string. The default is the `service_provider` fact from stdlib. To enforce this, we set the minimal string length for `prometheus::init_style`.
othalla
approved these changes
Jul 12, 2019
|
Thanks for the review! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
prohibit empty service_provider fact
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
prohibit empty service_provider fact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module depends on the variable
prometheus::init_stylebeing setto a string. The default is the
service_providerfact from stdlib.To enforce this, we set the minimal string length for
prometheus::init_style.Pull Request (PR) description
This Pull Request (PR) fixes the following issues