Support prometheus >= 2.0 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sathieu, thanks for this PR. Are you able to provide tests for this? |
|
@bastelfreak No. Sorry. |
|
Todo for me later: We can maybe add a simple acceptance test to prove this is working |
sathieu
added a commit
to sathieu/puppet-prometheus
that referenced
this pull request
Oct 23, 2017
Following voxpupuli#83, and preparing tests for voxpupuli#48.
|
PR updated with tests. |
|
Thanks for the unit tests @sathieu. We should probably add basic acceptance tests for this before we merge it. I will have a look later. |
|
I will test them in #86 |
|
@sathieu can you rebase please? Acceptance tests are now available in our master branch. |
sathieu
force-pushed
the
prom2.0
branch
2 times, most recently
from
9a0fabc to
4d84542
Compare
|
The acceptance tests are sometimes failing, but I think it's not due to this PR... |
|
Damn, I've no idea where the issue is. I thought I got it fixed while implementing the tests. |
|
can you restart those failing checks and see if it works? |
|
Restarted the failed one |
|
Thanks for this @sathieu! |
knackjax
pushed a commit
to knackjax/puppet-prometheus
that referenced
this pull request
Nov 21, 2017
Following voxpupuli#83, and preparing tests for voxpupuli#48.
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
Following voxpupuli#83, and preparing tests for voxpupuli#48.
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
Support prometheus >= 2.0
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Following voxpupuli#83, and preparing tests for voxpupuli#48.
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Support prometheus >= 2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.