Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support purging for all types of resources #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MaxFedotov
Copy link
Contributor

@MaxFedotov MaxFedotov commented Nov 12, 2018

Hello,

right now in some resources we have

  validate do
    raise('name parameter is required.') if (self[:ensure] == :present) && self[:name].nil?
    raise('hostname parameter is required.') if (self[:ensure] == :present) && self[:hostname].nil?
    raise('port parameter is required.') if (self[:ensure] == :present) && self[:port].nil?
  end

so the error is raised only in case if the resource should be present, but for some, it is not true.
So let's make this equal for all resource types and support purging for all of them

@MaxFedotov MaxFedotov force-pushed the make_resources_purgeable branch 3 times, most recently from ba36591 to e579214 Compare November 13, 2018 16:23
@saz
Copy link
Contributor

saz commented Nov 1, 2024

Fixes #161

@saz saz force-pushed the make_resources_purgeable branch from 02fed3f to 471b9ea Compare November 1, 2024 22:02
@saz saz force-pushed the make_resources_purgeable branch from 471b9ea to 277c7c0 Compare November 2, 2024 20:39
@saz saz removed the needs-tests label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants