-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure not detecting a pip version #617
Comments
if this idea makes sense to you, I can work on a PR. |
This regexp is barely readable 😒. PRs are always welcome, however, workaround for a problematic case should be avoided (e.g. setting In any case, the regexp looks wrong: Maybe we can find a way which which avoid completely this regexp, a quick look at the source makes me think we want to distinguish things like $grep_regex = $_ensure ? {
'present' => '...',
'absent' => '...',
'whatever' => '...',
default => '...',
} Opening a PR that add a unit test that demonstrate the problem is a very good first step! |
I'm trying to get the story because I'm not clear yet. |
I trend to agree: validating version numbers is a PITA and unless this is utterly needed, should be avoided IMHO. |
Affected Puppet, Ruby, OS and module versions/distributions
this is happening with the latest version of the module: 6.1.0
I am wondering if this is really the intended, and if we need to have a parameter to disable strict version checking:
for instance, I do have different software versions in our environments, as follows:
and only the latter is detected. It would accept 2.1.11, but not 2.1.11+xxxxx.
But rather than trying to fix this convoluted regex, would it make sense to have a parameter called
strict_version_checking
that can be set to true/false?The text was updated successfully, but these errors were encountered: