simplify packages version detection #618
Conversation
spec/acceptance/pip_spec.rb
Outdated
| describe command('/opt/test-venv/bin/pip show agent') do | ||
| its(:exit_status) { is_expected.to eq 1 } | ||
| its(:stdout) { is_expected.not_to match %r{WARNING: Package\(s\) not found: agent} } | ||
| end |
There was a problem hiding this comment.
Testing that something does not work in acceptance tests is a bit awkward because you have to test for the very exact error you are expecting. Here, Puppet cannot apply the catalog (because no package exist with this name and version) so the test should ensure that this is the exact error we are seeing.
It is probably easier to do a unit test in spec/defines/pip_spec.rb: setup python::pip with your parameters and ensure that the expected resources are declared with the expected parameters.
There was a problem hiding this comment.
@smortex I understand, but there is a problem. Indico is an application made by CERN, but we are customizing it, and those version numbers come from a colleague of mines. Unfortunately, they're not available in a public repository and they can't be used for this test.
On another note, this is the first time that I see "Github Actions", and the problem is that it's set to run on PRs, and I can't seem to find a way to run the test on my forked repo. I'll investigate a bit more.
maxadamo
force-pushed
the
fix-package-version-detection
branch
2 times, most recently
from
67a150e
to
f119bb6
Compare
|
I squashed the commits and fixed the CI. |
maxadamo
force-pushed
the
fix-package-version-detection
branch
from
f119bb6
to
9a1fd26
Compare
|
Dear @maxadamo, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
@maxadamo Any progress on this? |
|
@deric for me this change is working and it solves a real problem. I try to rebase and solve the conflicts ASAP. |
Pull Request (PR) description
Simplify packages version detection
This Pull Request (PR) fixes the following issues
Fixes #617