Allow no logfile to log to systemd-journald only #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Sep 24, 2024
| @@ -386,7 +387,7 @@ | |||
| Integer[0] $list_max_ziplist_value = 64, | |||
| Stdlib::Absolutepath $log_dir = $redis::params::log_dir, | |||
| Stdlib::Filemode $log_dir_mode = $redis::params::log_dir_mode, | |||
| String $log_file = 'redis.log', | |||
| Variant[Boolean[false], String[1]] $log_file = 'redis.log', | |||
There was a problem hiding this comment.
could you please add a unit test that sets this to false?
lbetz
force-pushed
the
allow-no-logfile
branch
from
cef2ae4
to
b77093a
Compare
|
mhm I'm not sure why it fails on Puppet 7 🤔 |
|
Who if not you? |
|
https://github.com/voxpupuli/puppet-redis/actions/runs/11087638787/job/30806564732?pr=535 at least we now know the issue is present in main. I assume it's a regression in Puppet 7 🤔 |
|
https://github.com/voxpupuli/puppet-redis/actions/runs/10890322096/job/30219882638 passed and maybe used Puppet 7.32.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Redis allows to set logfile to an empty string "" to disable logging to file.
if this is done, only the systemd-journald is logged.
This Pull Request (PR) fixes the following issues