Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package_version and package_source (baseurl) are not supported for Redhat/CentOS. #43

Closed
ozbillwang opened this issue Mar 30, 2015 · 9 comments

Comments

@ozbillwang
Copy link
Contributor

I need install old version, so I updated my hiera yaml file as below,

rundeck::package_version: '1.6.2-1.GA'
rundeck::package_ensure: present

It didn't work. Then I review the manifests/install.pp code, and found it didn't support properly for Redhat/centOS. it have hard-coding to install latest rundeck version and only from di.bintray.com, there is no chance you can choice the version and baseurl (package_source)

Second, there is no version 1.6 you can download from dl.bintray.com , lowest version is 2.0.

    'RedHat': {
      if $manage_yum_repo == true {
        yumrepo { 'bintray-rundeck':
          baseurl  => 'http://dl.bintray.com/rundeck/rundeck-rpm/',
          descr    => 'bintray rundeck repo',
          enabled  => '1',
          gpgcheck => '0',
          priority => '1',
          before   => Package['rundeck'],
        }
      }

      ensure_resource('package', 'rundeck', {'ensure' => $package_ensure} )
    }
@ozbillwang ozbillwang changed the title package_version and package_source (baseusr) are not supported for Redhat/CentOS. package_version and package_source (baseurl) are not supported for Redhat/CentOS. Apr 20, 2015
@ozbillwang
Copy link
Contributor Author

@liamjbennett any options for this issue?

@liamjbennett
Copy link
Member

The solution here is to re-implement the same download functionality that we have for Debian. It was there when I first wrote the module but then we moved to the package repo when I discovered its existence.

@ozbillwang
Copy link
Contributor Author

@liamjbennett will we get update in redhat/centos for my issue?

@liamjbennett
Copy link
Member

Yes, I will be working on this in the next day or so

@ozbillwang
Copy link
Contributor Author

My system (centos) find the latest version

[root@rundeck log]# yum list |grep rundeck
rundeck.noarch                  2.5.0-1.6.GA    @bintray-rundeck
rundeck-config.noarch           2.5.0-1.6.GA    @bintray-rundeck
rundeck.noarch                  2.5.1-1.7.GA    bintray-rundeck
rundeck-config.noarch           2.5.1-1.7.GA    bintray-rundeck

I will work out the puppet code to get the nominate version 2.5.1-1.7.GA to be installed and raise a pull request.

Ta

@ozbillwang
Copy link
Contributor Author

Finally I work it out. rundeck::package_version is useless for centos, so define the version in rundeck::package_ensure is enough.

rundeck::package_ensure: '2.5.1-1.7.GA'

And I got the updates:

Notice: /Stage[main]/Rundeck::Install/Package[rundeck]/ensure: ensure changed '2.5.0-1.6.GA' to '2.5.1-1.7.GA'

But rundeck-config is not updated, and rundeck service is not restarted automatically.

[root@rundeck log]# yum list installed |grep rundeck
rundeck.noarch              2.5.1-1.7.GA       @bintray-rundeck
rundeck-config.noarch       2.5.0-1.6.GA       @bintray-rundeck

@ozbillwang
Copy link
Contributor Author

Fix the service is not restarted issue, will follow with a pull request.

Notice: /Stage[main]/Rundeck::Install/Package[rundeck]/ensure: ensure changed '2.5.0-1.6.GA' to '2.5.1-1.7.GA'
Info: /Stage[main]/Rundeck::Install/Package[rundeck]: Scheduling refresh of Class[Rundeck::Service]
Info: Class[Rundeck::Service]: Scheduling refresh of Service[rundeckd]
Notice: /Stage[main]/Rundeck::Service/Service[rundeckd]: Triggered 'refresh' from 1 events

Here is the change in manifests/install.pp

      ensure_resource('package', 'rundeck', {'ensure' => $package_ensure, notify => Class['rundeck::service'] } )

ozbillwang added a commit to ozbillwang/puppet-rundeck that referenced this issue May 18, 2015
ozbillwang added a commit to ozbillwang/puppet-rundeck that referenced this issue May 18, 2015
…version after rundeck is upgraded in CentOS
@ozbillwang
Copy link
Contributor Author

commit cdd41e5 is raised to fix issue rundeck service is not restarted after upgraded in CentOS
commit 03e714d is raised to fix issue package rundeck_config is not upgraded to same version after rundeck is upgraded in CentOS

@ozbillwang
Copy link
Contributor Author

Pull request is #69

Please review and merge it. I am waiting the new rundeck release 2.5.1 to be upgraded in our system and depend on this change.

Thanks a lot.

liamjbennett pushed a commit that referenced this issue May 18, 2015
bugfix/#43 - rundeck service is not restarted after upgraded in CentOS
wcooley pushed a commit to wcooley/puppet-rundeck that referenced this issue May 21, 2015
wcooley pushed a commit to wcooley/puppet-rundeck that referenced this issue May 21, 2015
bastelfreak pushed a commit to bastelfreak/puppet-rundeck that referenced this issue Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants