Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key storage non-default dir path support #145

Merged
merged 1 commit into from
Oct 29, 2015
Merged

key storage non-default dir path support #145

merged 1 commit into from
Oct 29, 2015

Conversation

rooty0
Copy link
Contributor

@rooty0 rooty0 commented Oct 28, 2015

This feature allows to modify path of the key storage directory. (The Key Storage container allows storing public keys, private keys, and passwords)

related discussion: https://groups.google.com/forum/#!topic/rundeck-discuss/fzrQ26USTPU

@liamjbennett
Copy link
Member

The context for this change: http://rundeck.org/docs/administration/storage-facility.html

@liamjbennett
Copy link
Member

While I think this is a perfectly good change. I'm wondering if we can make it more generic and provide support for configuring other storage plugins as well.

@rooty0
Copy link
Contributor Author

rooty0 commented Oct 29, 2015

hey @liamjbennett, yeap, I was thinking about that, but that change (storage plugins) will be as a different task, need to spend some time on that.

This PR is just a quick fix-feature for non-standart key storage path support.
I can give a real life example.
I'm using rundeck within AWS and all data (like database, logs) should be on EBS, in my case it's "/rundeck". So I was able to change path almost for every resource. The only one thing that left - Key storage. What I understood from discussion with Greg, this PR is the only way to do that.

@liamjbennett
Copy link
Member

Ok, sounds reasonable.

liamjbennett pushed a commit that referenced this pull request Oct 29, 2015
key storage non-default dir path support
@liamjbennett liamjbennett merged commit be9e01a into voxpupuli:master Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants