Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to rundeck_version as a fact #165

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Move to rundeck_version as a fact #165

merged 1 commit into from
Jan 20, 2016

Conversation

jyaworski
Copy link
Member

Tagging @liamjbennett and @igalic.

I don't think that the fact existing on the systems is bad; I took this code almost directly from https://github.com/voxpupuli/puppet-collectd/blob/master/lib/facter/collectd_version.rb and it works fine. I actually ran into some errors because of the !defined in the facts class here.

@bastelfreak
Copy link
Member

Thanks for the contribution.

things that came up my mind:

  • rd-acl is available but not in $PATH
  • fact pollutes other nodes

first thing is prevented, @jyaworski told me that the binary is always placed in /usr/bin which is guaranteed by the deps/rpms. second thing is not an actual thing because the fact is nonexistend if the binary isn't found

@jyaworski
Copy link
Member Author

As a general note, I'm aware of fact pollution. There's really no good solution until environment isolation happens. This fact isn't heavy at all; if it were network or something, I'd consider it more heavily.

@bastelfreak
Copy link
Member

I'm fine with the fact. it gets execuded on all nodes but not created. 👍 from my side

bastelfreak added a commit that referenced this pull request Jan 20, 2016
@bastelfreak bastelfreak merged commit c169bbb into voxpupuli:master Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants