Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order variables alphabetically #189

Merged
merged 1 commit into from
Mar 2, 2016

Conversation

danifr
Copy link
Member

@danifr danifr commented Feb 29, 2016

#188

Some things to take into account:

  • I didn't change params.pp. Not sure if sorting makes sense here
  • I didn't sort any of the documented sections

What do you guys think?

@jyaworski
Copy link
Member

Ordering of the docs doesn't really matter. It would be nice if they were in the same order, though. It would make adding new docs easier.

@danifr
Copy link
Member Author

danifr commented Mar 1, 2016

Ordering of the docs doesn't really matter. It would be nice if they were in the same order, though. It would make adding new docs easier.

Any ideas on how to automate it? Doing it by hand seems like an endless task and incredibly error prone.

@danifr
Copy link
Member Author

danifr commented Mar 1, 2016

I kinda found a way to automate it. (thanks to http://stackoverflow.com/questions/6924816/sort-2-line-blocks-of-a-file)

This is how I did it:

  1. %s/*]\n/*]/g
  2. sort
  3. %s/*]/*]\r/g
  4. %s/# \[\*/#\r# \[\*/g

@jyaworski
Copy link
Member

Is this still WIP? Can you squash?

Ordered variables alphabetically
Sort docs
@danifr danifr changed the title [WIP] Order variables alphabetically Order variables alphabetically Mar 2, 2016
@danifr
Copy link
Member Author

danifr commented Mar 2, 2016

Yep, I think is ready to be merged. Thanks.

jyaworski added a commit that referenced this pull request Mar 2, 2016
@jyaworski jyaworski merged commit 4748a93 into voxpupuli:master Mar 2, 2016
@danifr danifr deleted the alphabetical_ordering branch March 2, 2016 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants