Implement installing as a package repo for redhat #2
Conversation
|
Will resubmit with passing tests. |
|
Thank you I appreciate the time taken with this contribution. I already had a TODO item for this, so I will be glad to merge it when your ready. |
|
Tests pass now. Give it a try. I have a few other fixes locally, various things were broken. |
|
Any chance of getting this merged? |
|
@liamjbennett ping |
|
@chandy apologies for the tardiness here - we have merged this PR and actually used this as a way of cleaning up some of our code. Thanks so much! |
|
Awesome, thank you! |
|
Thanks. I did find a number of other bugs in the module which i had to fix before it was usable. (just for one example, the indentation in the config files is broken in git, which kills rundeck.. you might have already fixed that now). If i get time i'll compare to latest and submit another patch. |
|
@ben57 apologies for not mentioning you in the close. If you see anything more then let me know :) |
This conversion is done by Transpec 2.3.7 with the following command:
transpec spec/unit/puppet/parser/functions/resources_deep_merge_spec.rb
* 2 conversions
from: == expected
to: eq(expected)
* 2 conversions
from: obj.should
to: expect(obj).to
For more details: https://github.com/yujinakayama/transpec#supported-conversions
This closes voxpupuli#2.
This needs to be fitpayops-rundeck when installing the module from the forge. Approved-by: Thomas Clukies <tom.clukies@fit-pay.com> Approved-by: Kexin Zhai <kexin.zhai@fit-pay.com>
Implemented installing packages via yum instead of manual exec commands for redhat.
I did not do debian.