Feature: Keytool

[zlanyi]

• feature: generate Keytool files
• fix: profile.erb due to "RDECK_SSL_OPTS"

[zlanyi]

Hi,
i did a new pull request because of the previous version of pull request (260) got a very strange commit .

Cheers,
Zoltan

[zlanyi]

I hope all things okay.

[zlanyi]

Hi Guys,
any news here?

Cheers,
Zoltan

[jyaworski]

@zlanyi can you rebase on the current master? It looks good.

[zlanyi]

"spec/acceptance/rundeck_spec.rb:5:5: C: RSpec/MultipleExpectations: Too many expectations."

[alexjfisher]

@zlanyi You could probably disable that cop for now by adding

# rubocop:disable RSpec/MultipleExpectations

to the top of the file. eg like in voxpupuli/puppet-archive@fcfc086

Other than than, could you rebase your PR instead of merging from upstream? If you're not that comfortable with git head on over to the #voxpupuli channel on Freenode IRC. Plenty of people willing to help you out there.

Thanks

[zlanyi]

@jyaworski : i did so the rebase
git checkout master
git pull upstream master
git checkout keytools2
git rebase master

its wrong?

[alexjfisher]

Ideally, the end result would be one or two logical commits, not the 13 here https://github.com/voxpupuli/puppet-rundeck/pull/261/commits

copy branch to keytool2 because of a strange commit from igalic is my favorite! ;)

Perhaps try a rebase -i master and do some squashing. But maybe best to make sure you have a safe copy of your branch first. git checkout keytools2; git checkout -b keytools2_backup; git checkout keytools2

[alexjfisher]

The .rubocop.yml file is managed by modulesync and shouldn't be edited manually. Could you disable the cop in the same manner as in voxpupuli/puppet-archive@fcfc086 by inserting the rubocop control comment at the first line of spec/acceptance/rundeck_spec.rb?

[zlanyi]

done

[alexjfisher]

@zlanyi Great! One last thing... You're now back up to 5 commits. Could you squash them down to just a single one with a suitable commit message?

Thanks.

[zlanyi]

@alexjfisher : thanks your support, done

[alexjfisher]

@zlanyi I'm really, really sorry for not merging this yet... But... could you fix up the English in the README?
(You can use git commit --amend to avoid creating a new commit)
Thanks.

[bbriggs]

This sentence needs a little more work in order to be clear to users.

Let's start with something like this:

"If ssl_enabled is True, you must supply this parameter. It is recommended that you provide the .crt and .key files separately via other means, such as a role or profile manifest."