Ad auth #29
Merged
Ad auth #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
November 24, 2014 15:24
… the nested hash rather than replace the entire key
…ficient' for all but the final authentication method
…rk properly. with '.*' access to all projects is denied
…omes before active_directory in the jaas-auth.conf.erb template
This reverts commit b30495c.
liamjbennett
pushed a commit
that referenced
this pull request
Nov 25, 2014
bastelfreak
pushed a commit
to bastelfreak/puppet-rundeck
that referenced
this pull request
Jan 13, 2017
fixing 2 typos that bugged me in the readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successfully tested against Active Directory to verify that the configuration works and both file based and AD based logins work. The ldap configuration looks correct however I didn't test against a live ldap server.
Change includes logic to set the authentication flag to sufficient for all but the last method in the authentication configuration. This allows each method to be tried and if fails it falls to the next method.
Switched the merge function to deep_merge for the auth_config to allow proper merging of nested hashes.