Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for additional preauth options #330

Merged
merged 1 commit into from
Nov 13, 2017

Conversation

jadestorm
Copy link

Hi folk!

This PR adds the ability to set the rest of the newer preauthenticated options (added via rundeck/rundeck#1883 in rundeck a few months ago). It should be harmless to older versions of rundeck as they will simply ignore the settings they don't know to look for.

@wyardley
Copy link
Contributor

wyardley commented Nov 10, 2017

@jadestorm can you rebase against current master, and update the tests, then squash?
https://github.com/voxpupuli/puppet-rundeck/blob/master/spec/classes/config/global/rundeck_config_spec.rb#L75-L105 should be the bit that needs to be updated.
Updating that heredoc should be sufficient, I think.

If you have questions, feel free to go to #voxpupuli on Puppet Community Slack or Freenode.

@jadestorm
Copy link
Author

Sure thing but it'll probably be Monday at the earliest before I get it taken care of. =)

@wyardley wyardley added the enhancement New feature or request label Nov 11, 2017
@wyardley
Copy link
Contributor

@jadestorm of course, whenever you have a chance.
Thanks for the PR

@juniorsysadmin
Copy link
Member

@jadestorm If you could use lowercase rather than camelCase for new things that would be great as well: https://puppet.com/docs/puppet/5.3/style_guide.html#variable-format . It doesn't look like we have been running puppet-lint on this module, and this will mean less clean up later.

@juniorsysadmin
Copy link
Member

Technically this is allowed for keys in a hash, but it would be nice to use lowercase were possible.

@wyardley
Copy link
Contributor

If you could use lowercase rather than camelCase for new things that would be great as well

@juniorsysadmin These are literal values for the Rundeck config, so I think they should be camelcase to follow Rundeck's convention (and may have to be?)

@jadestorm
Copy link
Author

@wyardley Woot, looks like she passed this time. =) Let me know if you have any other concerns/need me to tweak anything!

@wyardley wyardley merged commit 0f2d08f into voxpupuli:master Nov 13, 2017
@wyardley
Copy link
Contributor

@jadestorm Thanks for the contribution and for the quick fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants