-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for additional preauth options #330
Conversation
@jadestorm can you rebase against current master, and update the tests, then squash? If you have questions, feel free to go to #voxpupuli on Puppet Community Slack or Freenode. |
Sure thing but it'll probably be Monday at the earliest before I get it taken care of. =) |
@jadestorm of course, whenever you have a chance. |
@jadestorm If you could use lowercase rather than camelCase for new things that would be great as well: https://puppet.com/docs/puppet/5.3/style_guide.html#variable-format . It doesn't look like we have been running puppet-lint on this module, and this will mean less clean up later. |
Technically this is allowed for keys in a hash, but it would be nice to use lowercase were possible. |
@juniorsysadmin These are literal values for the Rundeck config, so I think they should be camelcase to follow Rundeck's convention (and may have to be?) |
@wyardley Woot, looks like she passed this time. =) Let me know if you have any other concerns/need me to tweak anything! |
@jadestorm Thanks for the contribution and for the quick fixes |
Hi folk!
This PR adds the ability to set the rest of the newer preauthenticated options (added via rundeck/rundeck#1883 in rundeck a few months ago). It should be harmless to older versions of rundeck as they will simply ignore the settings they don't know to look for.