Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed requirements for puppet-archive to allow version 2.x #344

Merged
merged 1 commit into from
Nov 10, 2017

Conversation

clxnetom
Copy link

@clxnetom clxnetom commented Nov 3, 2017

Looks like it's not breaking anything. As far as I can see it is only used in the rundeck::config::plugin class.

@wyardley
Copy link
Contributor

wyardley commented Nov 3, 2017

I think puppetlabs-java (even latest version) has this dependency:
puppet/archive (>= 1.1.0 < 2.0.0)
so that's why the acceptance test fails. It may need to be tested / dependency updated before this can get merged.

  	Error: Could not install module 'puppetlabs-java' (???)
  	  No version of 'puppetlabs-java' can satisfy all dependencies
  	    Use `puppet module install --ignore-dependencies` to install only this module

@alexjfisher
Copy link
Member

@wyardley puppetlabs-java has been updated, but not released yet. See puppetlabs/puppetlabs-java#261

@wyardley
Copy link
Contributor

It got released, I'm re-running the tests.

@wyardley wyardley self-requested a review November 10, 2017 01:05
@wyardley wyardley merged commit 0e32609 into voxpupuli:master Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants