add parameter to configure storage converter plugins #373
Conversation
| @@ -218,6 +221,7 @@ | |||
| Hash $framework_config = $rundeck::params::framework_config, | |||
| Stdlib::HTTPUrl $grails_server_url = $rundeck::params::grails_server_url, | |||
| Hash $gui_config = $rundeck::params::gui_config, | |||
| Hash $storage_converter = $rundeck::params::storage_converter, | |||
There was a problem hiding this comment.
@bastelfreak is this a positive comment?
There was a problem hiding this comment.
sure, I'm always happy about more datatypes
|
@agarco thanks for the PR! Can you take a look at the failing spec test? |
|
@agarco and maybe rebase the branch and squash all commits to one? (could also be done when merging). |
|
|
||
| describe 'rundeck' do | ||
| context 'supported operating systems' do | ||
| %w[Debian RedHat].each do |osfamily| |
There was a problem hiding this comment.
could you instead use rpsec-puppet-facts? That allows you to easily iterate on all operating systems in metadata.json. An example is https://github.com/voxpupuli/puppet-rundeck/blob/master/spec/classes/config_spec.rb#L6
|
Dear @ghost, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Added hash of properties to apply a storage converter plugin