feat(log4j): (optional) disable DailyRollingFileAppender #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for the PR! Can you please take a look at the failing tests and also and new ones for the new parameter? |
bastelfreak
reviewed
May 21, 2020
bastelfreak
reviewed
May 21, 2020
|
I've made the changes @bastelfreak suggested. I've also fixed the issues with the test, but there's still a single failing test. The error message isn't exactly helpful, but it doesn't look like it's related to my changes. |
|
I restarted the failed test and it succeeded. Can you please add a test for your change? |
Merged
|
Obsoleted by #520. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Introduces new optional variable rd_log4j_rotatedaily (default=true). This is needed for users that prefer logrotate over log4j.
This Pull Request (PR) fixes the following issues
n/a