Update repo location #474
Merged
Update repo location #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
commented
Aug 2, 2021
manifests/install.pp
Outdated
| yumrepo { 'bintray-rundeck': | ||
| yumrepo { 'rundeck': |
There was a problem hiding this comment.
Renaming the repo might be an issue if unmanaged repos are not purged. But since the old location seems to be unfetchable, this should not harm too much (I guess):
- users who purge unmanaged repo will not see anything;
- users who keep unmanaged repos will have errors when updating the available packages because some repository are broken, but the actual packages should be found.
There was a problem hiding this comment.
FWIW, the wholes packagecloud repos are a huge mess and tweaking parts of how they are managed does not make much sense I think. I refrained from dropping all tuning parameters other than $manage_repo, but I doubt anyone can make something useful out of it…
|
@bastelfreak Yes, it's the intention when it works :-) still WIP |
smortex
force-pushed
the
repo
branch
7 times, most recently
from
29e9c38
to
4c7b9e3
Compare
The rundeck packages seems to have been relocated. Update this location to unbreak CI.
|
@bastelfreak rebased on top of your changes, ready for review! |
bastelfreak
reviewed
Aug 6, 2021
Co-authored-by: Tim Meusel <tim@bastelfreak.de>
bastelfreak
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The rundeck packages seems to have been relocated. Update this location
to unbreak CI.
also contains:
This Pull Request (PR) fixes the following issues
Fixes #473
Fixes #469