Add syncLdapUser param to security_config #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosrio
changed the title
|
Adding some tests. |
|
@bastelfreak I can't seems to find why some tests are failling, could you give me a hand? |
This is the second run, to check for idempotency. Something is changing during that run. |
|
I believe that these checks started failling when #502 was merged. In fact, that PR do not have all checks passed. I am triying to debug why the second run is not idempotent but it is not related to the changes on thisI think. |
|
@bastelfreak can you help me to solve this errors? |
|
@bastelfreak please review |
bastelfreak
reviewed
Oct 10, 2023
bastelfreak
reviewed
Oct 10, 2023
bastelfreak
reviewed
Oct 10, 2023
bastelfreak
reviewed
Oct 10, 2023
add test fix test identation Add ldap user attributes to source the email and name properties fix lint fix rubocop fix typo fix add missing $ fix tests fix template logic try to fix tests Remove mvcc to fix tests undo unnecesary change Resolve comments
|
Done @bastelfreak :) |
bastelfreak
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add
rundeck.security.syncLdapUserto rundeck_config.groovy file. This flag enable using LDAP user attributes to update the email, first name, and last name properties of your Rundeck users.Add ldap user attributes used to source the email, and name properties.
Remove un used templates.
ref: https://docs.rundeck.com/docs/administration/security/authentication.html#ldap
This Pull Request (PR) fixes the following issues
Fixes #510
Fixes #416