Avoid service restarts on configuration changes and allow "resourcejson" as resource format. #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix avoids restarts of rundeck service on any configuration changes
|
What version of rundeck are you using because since 3.4.0 the support to manage projects has moved to DB and this module is not able to manage it yet through DB i mad a very big PR which will drop support for rundeck lower than 3.4.0 if you want you can put suggestions in there. |
Merged
|
Obsoleted by #520. |
|
Sorry for being so late on my answer. We are running Rundeck 4.17. So that should work. Will have a closer look into the new release next year. |
|
Yh sure i'm planning to add new features through rundeck cli for the projects/jobs so this PR will also be included in it as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Allow resource_format "resourcejson" as well, as it's allowed and working with rundeck.
Fix PR #486 to really avoid service restarts on configuration changes.
This Pull Request (PR) fixes the following issues
n/a