Enable "roleUsernameMemberAttribute" for LDAP auth (issue #62) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For sites using RFC 2307 posixGroup for roles, the *roleMemberAttribute* does not work, because the posixGroup *memberUid* attributes are usernames and not DNs; the *roleUsernameMemberAttribute* is for this. Since *role_member_attribute* is already specified in params, it is retained as the default unless *role_username_member_attribute* is set. I think these two are mutually exclusive, so there should be no case where they would both be enabled.
This was referenced May 12, 2015
liamjbennett
pushed a commit
that referenced
this pull request
May 15, 2015
…e_member_attribute Enable "roleUsernameMemberAttribute" for LDAP auth (issue #62)
bastelfreak
added a commit
to bastelfreak/puppet-rundeck
that referenced
this pull request
Jan 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For sites using RFC 2307 posixGroup for roles, the roleMemberAttribute does not work, because the posixGroup memberUid attributes are usernames and not DNs; the roleUsernameMemberAttribute is for this.