Support strict_variables by removing dynamic lookups #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh boy. So I just familiarized myself with strict_variables. I think I understand it's intent, but I now will have to overhaul every one of my modules and drop support for setting global variables via Dashboard (or some other ENC). :-( And to be pedantic: this module checks for top-scope variables and does not utilize dynamic lookups. |
|
This is getting necessary for newer puppet versions. |
|
Glanced at the patch, doesn't look like they are params which won't allow for modifaction. |
Closed
|
The pull request PR#79 correct the issue while allowing the modifications |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes a bunch of existing functionality. I would understand if you don't want to merge it.
My organization would like to enable strict_variables for our Puppet compilation. The current design of this module is not compatible with strict_variables, because it uses dynamic lookups to test for parameters. Dynamic lookups are deprecated.
With that in mind, I propose to remove these lookups entirely in favor of class parameters.