-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.0.0 #95
Release 3.0.0 #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also good to do a general review of metadata.json.
In this case, this:
"version_requirement": ">= 4.6.1 < 5.0.0"
should get bumped to >=4.7.1 < 6.0.0
, to support Puppet 5 and switch the lower limit to the current lowest Puppet version that Vox is supporting.
metadata.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "puppet-windowsfeature", | |||
"version": "3.0.0-rc0", | |||
"version": "2.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if I said it wrong or in a confusing way; if the new release will be 3.0.0, set the version to 3.0.0, then let the Travis release task bump to 3.0.1-rc0 directly in master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my mistake, thought it was already on 2.1.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/voxpupuli/puppet-windowsfeature/blob/v2.1.0/metadata.json#L32 << Since that was the last Puppet 3 release, we do need to go to 3.0.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Bumped metadata.json according to our supported version of puppet for vox |
Removed HISTORY.md. @wyardley |
Why did you remove the HISTORY.md? Looking at the changelog, you used it when running github-changelog-generator? By then removing it, the next time the changelog task is run, the pre 3.0.0 versions will get overwritten. |
@TraGicCode You were right about |
Working on cutting a new release again.
1.) There exist 2 bug fixes since the last release. Does this means we perform 2 patch releases? 1 for each bug fix or is a single patch release okay to contain 2 bug fixes?
2.) Do i need to do any massaging of the changelog titles?