refactoring of repo.pp #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bastelfreak
commented
Oct 5, 2015
bastelfreak
commented
- use yum variables in repo files ($releasever and $basearch)
- fix $releasever for PSBM
- switch the case for the repos to $::osfamily
- use one repo for all debian like OSes
- use one repo for all RHEL like OSes
- Update sid regex to not exclude jessie ( jessie is now present on the mirror)
|
This is a approach to fix the issue #123. This needs to be tested on Xen and aws (with amazon linux). @dj-wasabi please let me know what you think. |
bastelfreak
force-pushed
the
feature-PSBM
branch
from
7205e36 to
5df9dd2
Compare
|
Hi @bastelfreak It looks good, but I can't merge the PR. It has conflicts. Kind regards, |
bastelfreak
force-pushed
the
feature-PSBM
branch
from
dceade6 to
58ee710
Compare
- use yum variables in repo files ($releasever and $basearch) - fix $releasever for PSBM - switch the case for the repos to $::osfamily - use one repo for all debian like OSes - use one repo for all RHEL like OSes - Update sid regex to not exclude jessie ( jessie is now present on the mirror)
bastelfreak
force-pushed
the
feature-PSBM
branch
from
58ee710 to
edb9301
Compare
|
HI @dj-wasabi, everything green now, branch is mergeable :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.