Feature selinux

[bastelfreak]

two additions to make zabbix + selinux working. you maybe also need:

Selboolean{
  persistent  => true,
  value       => 'on',
}
selboolean{'httpd_can_network_connect_db': }
selboolean { 'httpd_can_network_connect': }

but this is really apache specific and should be handled by the apache module or by a profile. This PR is related to #190

[dj-wasabi]

Hi @bastelfreak

The CI build failed on this:

manifests/server.pp - WARNING: indentation of => is not properly aligned on line 512
manifests/server.pp - WARNING: indentation of => is not properly aligned on line 513
manifests/web.pp - ERROR: two-space soft tabs not used on line 412
manifests/web.pp - ERROR: two-space soft tabs not used on line 415
manifests/web.pp - WARNING: indentation of => is not properly aligned on line 413
manifests/web.pp - WARNING: indentation of => is not properly aligned on line 414

Can you check and fix this first? Then I'm able to merge this PR.

Thanks in advance.
Kind regards,
Werner

[bastelfreak]

I fixed the issues in server.pp. I'm not sure what is wrong with the web.pp, the code is fine, there aren't any hard tabs, only soft tabs. Every reformat I do there leads to new suspicious issues in that file.

[bastelfreak]

wuhu \o/
@dj-wasabi @ericsysmin could one of you take a look please?

[dj-wasabi]

Looks good to me. One thing before I merge, this only concerns the Server? Not the agent?

[bastelfreak]

These settings are only needed on the machine that runs the zabbix-server or the webfrontend. The agent itself doesn't need a selinux boolean in the default configuration. I just tested that on my CentOS 7 stuff with Zabbix 2.4

[dj-wasabi]

Ok, thanks!! 👍