enable STRICT_VAR for spec tests #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
okay, no difference. I've no clue:
I copied that change here from another module. maybe puppet checks for the env var by itself, or any fo the rake tasks does it. |
|
Hi @bastelfreak What do you want to do with this PR. Keep it open until you find something? Or is it readto to merge or close? Keep up the good work! 👍 👍 |
|
I digged through the gems, they should handle STRICT_VAR env by default. this doesn't seem to be needed. but I still don't know why travis didn't catch the error in #208. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this may allow CI to detect the issue in #208