Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modulesync 0.12.2 + Improvements #268

Merged
merged 12 commits into from
Aug 27, 2016
Merged

modulesync 0.12.2 + Improvements #268

merged 12 commits into from
Aug 27, 2016

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak changed the title modulesync 0.12.2 modulesync 0.12.2 + Improvements Aug 20, 2016
@bastelfreak bastelfreak added the needs-work not ready to merge just yet label Aug 20, 2016
@bastelfreak
Copy link
Member Author

bastelfreak commented Aug 20, 2016 •
edited
Loading

I'm trying to yak shave the tests to get more details about:

I had to modulesync first to fix puppet-lint.

@bastelfreak
fix error message
a0122ee
@bastelfreak
clean up spec tests for zabbix::agent
465e2f9
@bastelfreak
add test for presence of zabbix::startup
c472a24
@bastelfreak
cleanup zabbix::startup tests
273ecd2
@bastelfreak
remove wrong copryright notice
21a0321 
this file was introduced after Werner moved the module to Vox Pupuli.
Proof:
a41669a
@bastelfreak
Implement zabbix::startup with proper params
0694558 
this is an approch to fix the issues from:
#267
#266

we workaround the wrong scoping by adding suitable params. We validate
each of them in the defined resource.
@bastelfreak
manage selinux on every OS
e0d5fb1
@bastelfreak
implement rspec-puppet-facts for zabbix::server
757c2dc
@bastelfreak bastelfreak added the needs-feedback Further information is requested label Aug 21, 2016
@daenney
Copy link
Member

daenney commented Aug 21, 2016

This is too many changes in one go, which makes it really hard to follow in a PR. I would suggest you split out the improvement and the modulesync and raise them as PRs in that order.

@bastelfreak bastelfreak mentioned this pull request Aug 21, 2016
Merged
@jyaworski
Copy link
Member

This is good. The improvement is very minor, then rubocop stuff.

@jyaworski jyaworski merged commit fae91e7 into master Aug 27, 2016
@jyaworski jyaworski deleted the modulesync branch August 27, 2016 15:23
@bastelfreak bastelfreak added enhancement New feature or request and removed needs-feedback Further information is requested needs-work not ready to merge just yet labels Feb 12, 2017
@bastelfreak bastelfreak self-assigned this Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bastelfreak bastelfreak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @daenney @jyaworski