Bump min version_requirement for Puppet + deps #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juniorsysadmin
commented
Dec 26, 2016
| }, | ||
| { | ||
| "name": "puppetlabs/mysql", | ||
| "version_requirement": ">= 2.0.0" | ||
| "version_requirement": ">= 3.5.0 < 4.0.0" |
There was a problem hiding this comment.
Doesn't appear to be affected by breaking changes introduced by 3.0.0
|
not sure why travis failed, restarted the jobs |
|
please rebase |
|
the 'rebase and merge' button is really nice, a 'rebase and run tests and merge if green' would be awesome |
We currently only run automated tests against Puppet 3 latest and therefore cannot guarantee that this module works as is expected with earlier Puppet versions Bump dependencies to the minimum version that should work under Puppet 4, based on the metadata Also remove deprecated pe version_requirement field
juniorsysadmin
force-pushed
the
bumpdeps
branch
from
f4e30f4 to
76a325a
Compare
|
@bastelfreak done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only run automated tests against Puppet 3 latest and
therefore cannot guarantee that this module works as is expected with
earlier Puppet versions
Bump dependencies to the minimum version that should work under
Puppet 4, based on the metadata
Also remove deprecated pe version_requirement field