Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snap packaging #30

Merged
merged 4 commits into from
Aug 29, 2020
Merged

Add snap packaging #30

merged 4 commits into from
Aug 29, 2020

Conversation

jamesbeedy
Copy link
Contributor

Add snap packaging and documentation.

  • add snapcraft.yaml
  • add packaging/snap/README.md
  • update .gitignore

@mtds mtds self-assigned this Aug 29, 2020
@mtds mtds added the packaging label Aug 29, 2020
@mtds
Copy link
Collaborator

mtds commented Aug 29, 2020

Hi.

Thanks for the pull request, I will accept it but I will add two considerations:

  1. This exporter is rather small, I am not so sure it fits the use case of snap packaging, which I believe is more suited to deploy complex software (e.g. Chromium, etc.).
  2. I would not be 100% that the Snap packaging system will still be with us in the next five/ten years.....but this is just my humble opinion.

Anyway, I do not think it will harm anyone to add another option to distribute this exporter binary.

@mtds mtds merged commit 008653f into vpenso:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mtds mtds

Labels
packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesbeedy @mtds