Allow agent reuse for ClientSSLSecurity if forever option is set #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks a lot @Mik13 - could you please document the feature in our |
herom
reviewed
Oct 2, 2017
| if (!this.agent) { | ||
| options.keepAlive = true; | ||
|
|
||
| this.agent = new https.Agent(options); |
There was a problem hiding this comment.
Please initialize this property also within the constructor-function
herom
reviewed
Oct 2, 2017
test/security/ClientSSLSecurity.js
Outdated
| firstOptions.agent.should.not.equal(secondOptions.agent); | ||
| }); | ||
|
|
||
| it('should not generate different agents if paramter given', function () { |
There was a problem hiding this comment.
Please change the description to "should return the same agent if paramter is present"
|
You're welcome @herom. I've changed the test description and added a short documentation to the readme. I hope this works |
|
Awesome 💛 Thanks a ton @Mik13 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible for SSL connections to reuse the tls session. Every request, the https agent is recreated.
This PR changes this:
If the
foreverflag is set in the options per request (3rd parameter) or by default when setting the security (4th parameter), it should reuse the same agent as the previous requests also usingforever.The
request-Module handles everything else, like setting thekeep-alive-flag to the agent and the https module will cache the tls-session to the agent. Because of this, it is important that the same agent is used.Tests added