Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.3.1 - Added version checking & migration setup call #26

Merged
merged 3 commits into from
Feb 23, 2024
Merged

1.3.1 - Added version checking & migration setup call #26

merged 3 commits into from
Feb 23, 2024

Conversation

JordoVR
Copy link
Collaborator

@JordoVR JordoVR commented Feb 22, 2024

  • Commented out build target window as it's unreliable

Added version checking & migration setup call
1209aa3 
Commented out build target window
@JordoVR JordoVR self-assigned this Feb 22, 2024
@github-actions GitHub Actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

momo-the-monster
momo-the-monster reviewed Feb 22, 2024
View reviewed changes
vrchat.jordo.easyquestswitch/Runtime/EQS_Data.cs
public void OnSceneOpened()
{
buildInfo.NewBuildTarget = EditorUserBuildSettings.activeBuildTarget;
/*buildInfo.NewBuildTarget = EditorUserBuildSettings.activeBuildTarget;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you keeping this commented-out code to fix and add back in later? If so, I'd prefer to make a Linear task capturing the work to do and moving the WIP code there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already existing code for a feature I added in 1.2.0 but that had issues properly working (see #13), so for this release I'd like to comment it out (which I had planned to do before but hadn't made a release for it).
I'll make a task.

momo-the-monster
momo-the-monster approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@momo-the-monster momo-the-monster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a small change to commented-out code, otherwise looks alright.

@JordoVR JordoVR merged commit faec590 into vpm Feb 23, 2024
1 check failed
@JordoVR JordoVR deleted the 1.3.1 branch February 23, 2024 01:17
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@momo-the-monster momo-the-monster momo-the-monster approved these changes

Assignees

@JordoVR JordoVR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordoVR @momo-the-monster