Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed UnlitTransparentZWrite fallback on importing VRM 0.x #1139

Closed
Santarh opened this issue Aug 10, 2021 · 2 comments
Closed

Failed UnlitTransparentZWrite fallback on importing VRM 0.x #1139

Santarh opened this issue Aug 10, 2021 · 2 comments

Comments

@Santarh
Copy link
Contributor

Santarh commented Aug 10, 2021

importer

VRM/UnlitTransparentZWriteVRM/MToon にフォールバックしている。
しかし VRM/MToon の初期値は Unlit 状態ではないので、シェーダ変更だけでは正しいフォールバックにならない。

正しいフォールバックにするには、VRM/MToon に変更したうえで、その他のプロパティを適切に変更する必要がある。
たとえば Shade Color/Texture を Lit Color/Texture にそろえる、など。

{"VRM/UnlitTransparentZWrite", "VRM/MToon"},

exporter

VRM/UnlitTransparentZWriteKHR_materials_unlit にフォールバックしている。

case "VRM/UnlitTransparentZWrite":
return "KHR_materials_unlit";

@ousttrue ousttrue added this to the v0.81.0 milestone Aug 11, 2021
@ousttrue ousttrue modified the milestones: v0.81, v0.82 Aug 24, 2021
@ousttrue ousttrue modified the milestones: v0.82, v0.83 Sep 1, 2021
@ousttrue ousttrue modified the milestones: v0.83, v0.84 Sep 9, 2021
@ousttrue ousttrue modified the milestones: v0.84, v0.85 Sep 17, 2021
@emilianavt
Copy link
Contributor

This issue breaks some existing models quite noticeably.

Current fallback happening to the blush material:
Fallback

Correct behaviour:
Correct

@ousttrue ousttrue changed the title Failed shader fallback on importing VRM 0.x Failed UnlitTransparentZWrite fallback on importing VRM 0.x Sep 28, 2021
@ousttrue
Copy link
Contributor

It will be fixed in the next v0.85.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants