Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VRM/UnlitTransparentZWrite の Import を修正 #1248

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Sep 27, 2021

#1139

MToon へのフォールバック時に同じような見た目になるようにプロパティを書き換え。

主要な変更

  • VRMMaterialDescriptorGenerator
  • VRMZWriteMaterialImporter

ついで

  • UniUnilt.UtilsUniUnlit.UniUnlitUtil に rename 。 ( using 時に Utils だと分かりづらいため )
  • const UniUnlit.UniUnlitUtil.ShaderName を使うように修正

Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

とりあえずよさそう。
ただ、Unlit 性が失われているので、それは修正出します~

MaterialDescriptor matDesc;

// legacy "VRM/UnlitTransparentZWrite"
if (VRMZWriteMaterialImporter.TryCreateParam(data, m_vrm, i, out matDesc))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここで分岐

@ousttrue ousttrue merged commit 67cba5f into vrm-c:master Sep 28, 2021
@ousttrue ousttrue deleted the fix/zwrite_import branch October 27, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants