Skip mesh export when MeshExportInfo.CanExport is false #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichi-23
commented
Jul 27, 2021
| @@ -247,6 +247,11 @@ public virtual void Export(GltfExportSettings meshExportSettings, ITextureSerial | |||
| MeshBlendShapeIndexMap = new Dictionary<Mesh, Dictionary<int, int>>(); | |||
| foreach (var unityMesh in uniqueUnityMeshes) | |||
| { | |||
| if (!unityMesh.CanExport) | |||
| { | |||
| continue; | |||
There was a problem hiding this comment.
continue する前に何かログに出力したほうがいいかもしれない
ichi-23
commented
Jul 27, 2021
| { | ||
| continue; | ||
| } | ||
|
|
||
| var (gltfMesh, blendShapeIndexMap) = meshExportSettings.DivideVertexBuffer | ||
| ? MeshExporter_DividedVertexBuffer.Export(glTF, bufferIndex, unityMesh, Materials, m_settings.InverseAxis.Create(), meshExportSettings) |
There was a problem hiding this comment.
- mesh の vertexCount が 0 の場合、ArgumentOutOfRangeException が発生する
- mesh が null の場合、NullReferenceException が発生する
ichi-23
commented
Jul 27, 2021
| { | ||
| continue; | ||
| } | ||
|
|
||
| var (gltfMesh, blendShapeIndexMap) = meshExportSettings.DivideVertexBuffer | ||
| ? MeshExporter_DividedVertexBuffer.Export(glTF, bufferIndex, unityMesh, Materials, m_settings.InverseAxis.Create(), meshExportSettings) | ||
| : MeshExporter_SharedVertexBuffer.Export(glTF, bufferIndex, unityMesh, Materials, m_settings.InverseAxis.Create(), meshExportSettings) |
There was a problem hiding this comment.
- mesh の vertexCount が 0 の場合処理が正常に終了するが、空の Mesh が Export されることになる
- mesh が null の場合、NullReferenceException が発生する
ousttrue
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MeshExportInfo.CanExportが false である場合、その mesh の export をスキップするなぜそうしたいか
MeshExportList.GetInfoで集めたMeshExportInfoの中には「Export 可能ではない Mesh の情報」（Mesh が null であったり、Mesh の vertexCount が 0 だったりするもの）が存在しうるMeshExportInfoが渡された場合のハンドリングが抜けているMeshExporter_DividedVertexBuffer.ExportならびにMeshExporter_SharedVertexBuffer.Exportは Mesh が null ではない、Mesh の vertexCount が 0 ではないこと前提の処理となっており、そうでないMeshExportInfoが渡された場合 Exception が発生するMeshExportInfo.CanExportを見ればよい）であるため、CanExport が false の場合対象の mesh の export をスキップしたい