Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VRM10Expression.Preset と ExpressionName を廃止 #1141

Merged
merged 1 commit into from
Aug 11, 2021
Merged

VRM10Expression.Preset と ExpressionName を廃止 #1141

merged 1 commit into from
Aug 11, 2021

Conversation

ousttrue
Copy link
Contributor

  • VRM10Expression.Preset は VRM10ObjectExpression　のどのスロットにセットされているかで判定
  • VRM10Expression.ExpressionName は VRM10Expression.name を使う

vrm-c/vrm-specification#296 で、
Expression をコレクションに格納するのをやめて、固定のフィールドに保持するように変更した。
実装の追随。

@ousttrue
VRM10Expression.Preset と ExpressionName を廃止
9592905 
* VRM10Expression.Preset は VRM10ObjectExpression　の度のスロットにセットされているかで判定
* VRM10Expression.ExpressionName は VRM10Expression.name を使う
@ousttrue ousttrue added this to the v0.80 milestone Aug 10, 2021
@ousttrue ousttrue requested review from Santarh and PoChang007 August 10, 2021 10:53
@PoChang007 PoChang007 merged commit 1927849 into vrm-c:master Aug 11, 2021
@ousttrue ousttrue deleted the feature1/remove_expression_preset branch October 27, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PoChang007 PoChang007 PoChang007 approved these changes

@Santarh Santarh Awaiting requested review from Santarh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.80
Development

Successfully merging this pull request may close these issues.
2 participants
@ousttrue @PoChang007