Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add [HDR] #1151

Merged
merged 1 commit into from
Aug 17, 2021
Merged

add [HDR] #1151

merged 1 commit into from
Aug 17, 2021

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Aug 13, 2021 •
edited
Loading

#1148

とりあえず。

@ousttrue ousttrue requested a review from Santarh August 13, 2021 04:23
@Santarh
Copy link
Contributor

Santarh commented Aug 17, 2021

UniVRM/Assets/VRM10/Runtime/IO/Material/Vrm10MToonMaterialExporter.cs

Line 89 in dd31a7d

dst.emissiveFactor = context.EmissiveFactorLinear.ToFloat3(ColorSpace.Linear, ColorSpace.Linear);

UniVRM/Assets/VRM10/Runtime/IO/Material/Vrm10MToonMaterialImporter.cs

Line 85 in dd31a7d

var emissionColor = material?.emissiveFactor?.ToColor3(gltfColorSpace, ColorSpace.Linear);

IO は Linear 想定で書かれていたので、単純に適用漏れかなと思われます。

@ousttrue ousttrue merged commit 2e50a09 into vrm-c:master Aug 17, 2021
@ousttrue ousttrue added the colorspace gamma(sRGB) / Linear label Sep 9, 2021
@ousttrue ousttrue deleted the fix1/mtoon_emission_hdr branch October 27, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santarh Santarh Santarh approved these changes

Assignees
No one assigned
Labels
colorspace gamma(sRGB) / Linear
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ousttrue @Santarh