[1.0] TextureTransformBind の Scale/Offset 変換 #1234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Santarh
previously approved these changes
Sep 21, 2021
| /// <returns></returns> | ||
| public static (Vector2, Vector2) VerticalFlipScaleOffset(Vector2 s, Vector2 o) | ||
| { | ||
| return (new Vector2(s.x, s.y), new Vector2(o.x, 1.0f - o.y - s.y)); |
| /// <param name="s"></param> | ||
| /// <param name="o"></param> | ||
| /// <returns></returns> | ||
| public static (Vector2, Vector2) VerticalFlipScaleOffset(Vector2 s, Vector2 o) |
There was a problem hiding this comment.
（どちらでもよい）タプルに名前を付けておいた方が、メンテ性はあるかも。
public static (Vector2 scale, Vector2 offset) VerticalFlipScaleOffset(Vector2 scale, Vector2 offset)
There was a problem hiding this comment.
たしかに。わりと OffsetScale と言っていることがある。
There was a problem hiding this comment.
計算を適用する順序としては uv * scale + offset なので ScaleOffset の方が間違いが少ないという気持ちはある
微妙なところ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ついでに実験してみた。