Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] FirstPerson.SetupAsync 修正 #1252

Merged
merged 2 commits into from
Sep 28, 2021
Merged

[1.0] FirstPerson.SetupAsync 修正 #1252

merged 2 commits into from
Sep 28, 2021

Conversation

ousttrue
Copy link
Contributor

#1242

  • FirstPerson.SetupAsync の仕様を変更(中で AddRenderer する)
  • SkinnedMeshRenderer.updateWhenOffscreen = true しない (あとで EnableUpdateWhenOffscreen )
  • AddComponent 直後に SkinnedMeshRenderer.enabled = false
  • AddRenderer のバグ修正 (_skinnedMeshRenderers に Add してなかった)

@ousttrue ousttrue added importer LookAt/FirstPerson create headless model for VR labels Sep 28, 2021
@ousttrue ousttrue added this to the v0.85 milestone Sep 28, 2021
@ousttrue ousttrue requested a review from Santarh September 28, 2021 08:10
Santarh
Santarh approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいんじゃないでしょうか

docs/vrm1/vrm1_firstperson.md
// 3.
var created = await controller.Vrm.FirstPerson.SetupAsync(controller.gameObject);
// 3. The headless model that created is added to instance
await controller.Vrm.FirstPerson.SetupAsync(controller.gameObject);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

最小限でよさそう。

Assets/VRM10/Runtime/Components/VRM10Object/VRM10ObjectFirstPerson.cs
@@ -49,20 +49,22 @@ private async static Task<SkinnedMeshRenderer> CreateHeadlessMeshAsync(SkinnedMe

var go = new GameObject("_headless_" + renderer.name);
var erased = go.AddComponent<SkinnedMeshRenderer>();
erased.enabled = false; // hide
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

生成するときに Renderer は disable。

@ousttrue ousttrue merged commit 449e072 into vrm-c:master Sep 28, 2021
@ousttrue ousttrue deleted the fix10/fix_firstperson_setup branch October 27, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santarh Santarh Santarh approved these changes

Assignees
No one assigned
Labels
importer LookAt/FirstPerson create headless model for VR
Projects
None yet
Milestone
v0.85
Development

Successfully merging this pull request may close these issues.
2 participants
@ousttrue @Santarh