Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add self flag #1258

Merged
merged 1 commit into from
Sep 29, 2021
Merged

add self flag #1258

merged 1 commit into from
Sep 29, 2021

Conversation

ousttrue
Copy link
Contributor

#1250

要するに、自分以外の VRMFirstPersonOnly フラグがあった場合に、その Renderer を非表示にする。

@ousttrue ousttrue requested a review from Santarh September 29, 2021 04:12
@ousttrue ousttrue added this to the v0.85 milestone Sep 29, 2021
@ousttrue ousttrue added the LookAt/FirstPerson create headless model for VR label Sep 29, 2021
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそう。

}
else
{
switch (x.FirstPersonFlag)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

モデルが非ユーザのモデルの場合、モデル分割などの処理は入らない。

唯一、ユーザが FirstPersonOnly を明示的に設定したレンダラのみが無効化される。

@ousttrue ousttrue merged commit 39c7af6 into vrm-c:master Sep 29, 2021
@ousttrue ousttrue deleted the fix10/firstperson_isSelf branch October 27, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LookAt/FirstPerson create headless model for VR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants