Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VrmLib.Model の Read を非同期処理フェーズに移動 #1259

Merged
merged 1 commit into from
Sep 29, 2021
Merged

VrmLib.Model の Read を非同期処理フェーズに移動 #1259

merged 1 commit into from
Sep 29, 2021

Conversation

Santarh
Copy link
Contributor

@Santarh Santarh commented Sep 29, 2021

コンストラクタ呼び出しで 20ms などかかっている処理を LoadAsync 側に持っていった

@Santarh Santarh requested a review from ousttrue September 29, 2021 04:16
ousttrue
ousttrue approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@ousttrue ousttrue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vrmlib は Unity 非依存なのでスレッドにしても大丈夫

@ousttrue ousttrue merged commit a5e1726 into vrm-c:master Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ousttrue ousttrue ousttrue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Santarh @ousttrue