Fix dictionary deserializer #189
Conversation
ousttrue
commented
Feb 12, 2019
ousttrue
commented
- JsonDictionaryValidator.Deserialize is not implemented
- Fix dictionary member serialization
| @@ -219,10 +219,32 @@ public void HumanoidTest() | |||
| [Test] | |||
| public void MaterialTest() | |||
| { | |||
| var model = new glTF_VRM_Material(); | |||
| var model = new glTF_VRM_Material | |||
There was a problem hiding this comment.
Could you add this test case as a new unit tests?
There was a problem hiding this comment.
Simple case is 0eff571#diff-1967e80b396b0aed6d6a20cb02357f56R162
Addition of MaterialTest is extra.
There was a problem hiding this comment.
I see. It is OK if you can say that the test case previously checked is not affected by changes in this PR.
| // deserialize | ||
| var deserialized = default(glTF_VRM_Material); | ||
| json.ParseAsJson().Deserialize(ref deserialized); | ||
| Assert.AreEqual(1, deserialized.floatProperties.Count); |
There was a problem hiding this comment.
I think that element values should be checked not only checking number of elements. Same comments for other fields.
| DeserializeValue(HogeFuga.Fuga, "1"); | ||
|
|
||
| DeserializeValue(new EnumTest(), "{\"EnumDefault\":0,\"EnumAsInt\":0,\"EnumAsString\":\"Hoge\",\"EnumAsLowerString\":\"hoge\"}"); | ||
| DeserializeValue(new DictionaryValue(), "{\"Dict\": {}}"); |
There was a problem hiding this comment.
Simple case is here
| @@ -219,10 +219,32 @@ public void HumanoidTest() | |||
| [Test] | |||
| public void MaterialTest() | |||
| { | |||
| var model = new glTF_VRM_Material(); | |||
| var model = new glTF_VRM_Material | |||
There was a problem hiding this comment.
Simple case is 0eff571#diff-1967e80b396b0aed6d6a20cb02357f56R162
Addition of MaterialTest is extra.
|
以後、日本語で。 |
