Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extensions.VRM.specVersion to the json schema #197

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Add extensions.VRM.specVersion to the json schema #197

merged 1 commit into from
Mar 13, 2019

Conversation

saturday06
Copy link
Contributor

specVersionの記述がjson schemaに存在しなかったため、記述を追加しました。

yutopp
yutopp approved these changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@yutopp yutopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。LGTMです。

NOTE: specVersionはrequiredではないため、これまでのフィールドが存在していないデータに関しても互換性あり。

@yutopp yutopp requested a review from ousttrue February 18, 2019 14:43
@yutopp
Copy link
Contributor

yutopp commented Feb 18, 2019

specの変更なので、念のため2checksでマージしたいです。

@yutopp yutopp requested review from hiroj and removed request for ousttrue March 13, 2019 06:25
@hiroj hiroj merged commit e4b0f33 into vrm-c:master Mar 13, 2019
@saturday06 saturday06 deleted the specversion-schema branch March 15, 2019 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutopp yutopp yutopp approved these changes

@hiroj hiroj Awaiting requested review from hiroj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saturday06 @yutopp @hiroj