Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imports with UniGLTF 1.28 look less like Blender equivalent than 1.27 #388

Closed
DavidAntliff opened this issue Apr 12, 2020 · 2 comments
Closed

Comments

@DavidAntliff
Copy link

DavidAntliff commented Apr 12, 2020

This isn't a bug, it's a question about UniGLTF.

I used UniGLTF 1.27 and UniFLTF 1.28 (part of UniVRM-0.55.0) to import the KhronosGroup FlightHelmet model into Unity 2019.3. I also used "Edit > Render Pipeline > Universal Render Pipeline > Update Selected Materials to UniversalRP Materials" to update the imported materials to work with the Universal Render Pipeline.

I notice that I get visibly different results:

image

The front instance (on the left) is from 1.27, the rear instance (on the right) is from 1.28. I notice that the 1.28 version is a lot less reflective than 1.27. I thought that this might be expected due to the changelog notes for 1.28, and the FAQ, but when I compare with the .gltf imported into Blender, I see that it more closely matches version 1.27:

image

Note the specularity of the leather helmet and the nose and mouthpiece - the Blender image looks more like the front/left 1.27 image than the newer 1.28 image. The specular highlights on the hose in v1.27 are also closer to the Blender image.

I realise this is a fairly subjective opinon, so I'm looking for the technically correct answer. Is 1.27 more correct? Or is v1.28 more correct?

@hiroj
Copy link
Contributor

hiroj commented Apr 13, 2020

Thank you for the report.
I could see the difference in the reflection.
I will investigate.

@ousttrue ousttrue modified the milestones: v0.66, v0.67 Jan 29, 2021
@ousttrue ousttrue modified the milestones: v0.67, v0.68, v0.69 Feb 10, 2021
ousttrue added a commit to ousttrue/UniVRM that referenced this issue Mar 11, 2021
ousttrue added a commit to ousttrue/UniVRM that referenced this issue Mar 16, 2021
ousttrue added a commit to ousttrue/UniVRM that referenced this issue Mar 16, 2021
ousttrue added a commit to ousttrue/UniVRM that referenced this issue Mar 17, 2021
@ousttrue
Copy link
Contributor

v0.69.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants