Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修 #780

Merged
merged 28 commits into from
Mar 17, 2021

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Mar 11, 2021

// GLTF
        {
            "pbrMetallicRoughness": {
                "baseColorTexture": {
                    "index": 11
                },
                "metallicRoughnessTexture": {
                    "index": 10
                }
            },
            "normalTexture": {
                "index": 9
            },
            "occlusionTexture": {
                "index": 10
            },
            "name": "LeatherPartsMat"
        },

inspector

// unity(smoothness) <= gltf(rougheness)
pixel(unity) = 1 - pixel(gltf) * factor(gltf)
factor(unity) = 1

// gltf(roughness) <= unity(smoothness)
pixel(gltf) = 1 - pixel(unity) * factor(unity)
factor(gltf) = 1

@ousttrue
Copy link
Contributor Author

@ousttrue ousttrue changed the title [WIP] Fix/roughness smooth conversion MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修 Mar 15, 2021
@ousttrue
Copy link
Contributor Author

Exported and imported immediately

@ousttrue ousttrue force-pushed the fix/roughness_smooth_conversion branch 2 times, most recently from 25616c6 to 3f597d3 Compare March 16, 2021 08:53
@ousttrue ousttrue changed the title MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修 [WIP] MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修 Mar 16, 2021
@ousttrue ousttrue force-pushed the fix/roughness_smooth_conversion branch from 3f597d3 to 1d38656 Compare March 17, 2021 06:42
@ousttrue ousttrue changed the title [WIP] MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修 MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修 Mar 17, 2021
@ousttrue ousttrue requested a review from Santarh March 17, 2021 06:56
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

さすがにデカすぎて見きれませんが、ちゃんと動いているならヨシということで…

@ousttrue ousttrue merged commit f55cd3e into vrm-c:master Mar 17, 2021
@ousttrue ousttrue added this to the v0.69 milestone Mar 17, 2021
@ousttrue ousttrue deleted the fix/roughness_smooth_conversion branch April 2, 2021 04:33
@ousttrue ousttrue added the colorspace gamma(sRGB) / Linear label Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
colorspace gamma(sRGB) / Linear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants