-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修 #780
Merged
ousttrue
merged 28 commits into
vrm-c:master
from
ousttrue:fix/roughness_smooth_conversion
Mar 17, 2021
Merged
MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修 #780
ousttrue
merged 28 commits into
vrm-c:master
from
ousttrue:fix/roughness_smooth_conversion
Mar 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ousttrue
commented
Mar 11, 2021
•
edited
Loading
edited
- Imports with UniGLTF 1.28 look less like Blender equivalent than 1.27 #388 glTF(roughness) と unity(smoothness) の変換を修正
- Combine PBR textures into one #781 imoport時に(metallic,roughness,occlusion)を1枚にまとめる。export時に(metallic,smoothness,occlusion)を1枚にまとめる
- TextureExport 周りのコードを単純化(inteface や継承をやめて、 static class, static 関数を増やした)
ousttrue
changed the title
[WIP] Fix/roughness smooth conversion
MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修
Mar 15, 2021
ousttrue
force-pushed
the
fix/roughness_smooth_conversion
branch
2 times, most recently
from
March 16, 2021 08:53
25616c6
to
3f597d3
Compare
ousttrue
changed the title
MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修
[WIP] MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修
Mar 16, 2021
ousttrue
force-pushed
the
fix/roughness_smooth_conversion
branch
from
March 17, 2021 06:42
3f597d3
to
1d38656
Compare
ousttrue
changed the title
[WIP] MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修
MetallicRoughnessOcclusion テクスチャーの取り廻しを中心に改修
Mar 17, 2021
Santarh
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
さすがにデカすぎて見きれませんが、ちゃんと動いているならヨシということで…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.